Fix(quadlet): Ensure .app application file is removed by quadlet rm --all (#27647) by kavishgr · Pull Request #27694 · podman-container-tools/podman

kavishgr · 2025-12-05T08:19:49Z

Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
the sign-off email address. See CONTRIBUTING.md
for more information.
Referenced issues using Fixes: #00000 in commit message (if applicable)
Tests have been added/updated (or no tests are needed)
Documentation has been updated (or no documentation changes are needed)
All commits pass make validatepr (format/lint checks)
Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Fixes: #27647

Note on Dependencies:

This PR is dependent on the changes from issue #27653, as outlined in PR #27693. Once #27693 merges, I will rebase and push the changes here.

What I did (quadlet.go file):

Fixed reverseMap lookup by using the base filename instead of the full path, since reverseMap keys are filenames only
Added conditional path handling when expanding quadlets from .app files - use full paths when --all flag is set (since getAllQuadletPaths returns full paths), but use just filenames otherwise (since getQuadletPathByName expects filenames)
Moved the cleanup of .app and .asset metadata files outside the main quadlet removal loop. Previously these files were being left behind because they aren't included in allQuadletPaths. Now they're properly removed after all quadlets have been processed
Added logging for the files being removed

These changes fix the issue where .app files were not being deleted during removal(podman quadlet --all --force), and also resolve path resolution errors when removing individual apps (e.g., podman quadlet rm .nginx-test.app).

Test:

The test verifies that the podman quadlet rm -af command correctly removes all quadlet files.

openshift-ci · 2025-12-05T08:19:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kavishgr
Once this PR has been reviewed and has the lgtm label, please assign honny1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Honny1

I did a quick check of the CI failure. I also fixed the release note format in the PR description.

…ntainer-tools#27653) Fix: removed return statement, which was originally added for logging. Logrus handles the logging(in its related PR podman-container-tools#27694). Signed-off-by: Kavish Gour <kavishgr@protonmail.com>

kavishgr · 2025-12-08T04:15:01Z

This PR now includes all necessary changes. We should abandon PR #27693 and only merge this current one.

Honny1

The code LGTM. However, I have a question about the tests: is there a specific reason they weren't implemented in quadlet_test.go?

kavishgr · 2025-12-08T14:55:20Z

The code LGTM. However, I have a question about the tests: is there a specific reason they weren't implemented in quadlet_test.go?

On a closed PR regarding quadlets, a collaborator suggested that all quadlet tests should go into 36-quadlets.at. I think I might’ve misunderstood that, sorry about the mix up. I can write it in Ginkgo. I recently ran one and it passed. I can implement the rm -af tests using Podman commands, and we can keep the Libpod API test as it is

ygalblum

Small nit

ygalblum · 2025-12-08T15:30:47Z

+#
+# Install quadlets(.container, .network, .volume)
+
+quadlet_name=quadlet-rm-test-$(cat /proc/sys/kernel/random/uuid)


Use safename (defined in helpers.bash)

Got it. Thanks.

Sorry, my bad, I though this was a bats test. I'm not sure this one has the safename

No worries. I've updated the test name to quadlet-remove-all-test to keep it consistent.

Honny1 · 2025-12-08T15:40:18Z

The code LGTM. However, I have a question about the tests: is there a specific reason they weren't implemented in quadlet_test.go?

On a closed PR regarding quadlets, a collaborator suggested that all quadlet tests should go into 36-quadlets.at. I think I might’ve misunderstood that, sorry about the mix up. I can write it in Ginkgo. I recently ran one and it passed. I can implement the rm -af tests using Podman commands, and we can keep the Libpod API test as it is

Yes, please write a simple test in Ginkgo.

packit-as-a-service · 2025-12-08T18:33:11Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-12-08T18:33:11Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-12-08T18:33:11Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1

LGTM, please rebase on main.

kavishgr · 2025-12-18T16:21:35Z

LGTM, please rebase on main.

Done. Rebased on latest main.

Honny1 · 2025-12-22T11:00:17Z

+
+			installSession := podmanTest.Podman([]string{"quadlet", "install", tmpDir})
+			installSession.WaitWithDefaultTimeout()
+			Expect(installSession).Should(Exit(0))


This still fails on F43. I am not sure where the problem could be.

[FAIL] quadlet system generator Running quadlet force remove all [It] Should remove all quadlets at once [+0894s] /var/tmp/go/src/github.com/containers/podman/test/e2e/quadlet_test.go:1360

I ran the tests and they passed on my end. Here is the output:

❯ sudo ginkgo -v -focus "Running quadlet force remove all" test/e2e Running Suite: Libpod Suite - /home/kavish/podman/test/e2e ========================================================== Random Seed: 1766421735 Will run 1 of 2443 specs ------------------------------ [SynchronizedBeforeSuite] /home/kavish/podman/test/e2e/common_test.go:169 [image already cached: /var/tmp/quay.io-libpod-cirros-latest.tar] [image already cached: /var/tmp/quay.io-libpod-volume-plugin-test-img-20220623.tar] [image already cached: /var/tmp/quay.io-libpod-alpine-latest.tar] [image already cached: /var/tmp/quay.io-libpod-busybox-latest.tar] [image already cached: /var/tmp/quay.io-libpod-systemd-image-20240124.tar] [image already cached: /var/tmp/quay.io-lsm5-alpine_nginx-aarch64-latest.tar] [image already cached: /var/tmp/quay.io-libpod-redis-alpine.tar] [image already cached: /var/tmp/quay.io-libpod-registry-2.8.2.tar] [image already cached: /var/tmp/quay.io-libpod-k8s-pause-3.5.tar] [image already cached: /var/tmp/quay.io-libpod-testimage-20241011.tar] [image already cached: /var/tmp/quay.io-libpod-alpine_healthcheck-latest.tar] [image already cached: /var/tmp/quay.io-libpod-systemd-image-20240124.tar] Restoring quay.io/libpod/alpine:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-alpine-latest.tar Loaded image: quay.io/libpod/alpine:latest Restoring quay.io/libpod/busybox:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-busybox-latest.tar Loaded image: quay.io/libpod/busybox:latest Restoring quay.io/libpod/systemd-image:20240124... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-systemd-image-20240124.tar Loaded image: quay.io/libpod/systemd-image:20240124 Restoring quay.io/lsm5/alpine_nginx-aarch64:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-lsm5-alpine_nginx-aarch64-latest.tar Loaded image: quay.io/lsm5/alpine_nginx-aarch64:latest Restoring quay.io/libpod/redis:alpine... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-redis-alpine.tar Loaded image: quay.io/libpod/redis:alpine Restoring quay.io/libpod/registry:2.8.2... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-registry-2.8.2.tar Loaded image: quay.io/libpod/registry:2.8.2 Restoring quay.io/libpod/k8s-pause:3.5... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-k8s-pause-3.5.tar Loaded image: quay.io/libpod/k8s-pause:3.5 Restoring quay.io/libpod/testimage:20241011... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-testimage-20241011.tar Loaded image: quay.io/libpod/testimage:20241011 Restoring quay.io/libpod/alpine_healthcheck:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-alpine_healthcheck-latest.tar Loaded image: quay.io/libpod/alpine_healthcheck:latest Restoring quay.io/libpod/systemd-image:20240124... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-systemd-image-20240124.tar Loaded image: quay.io/libpod/systemd-image:20240124 ----------------------------- [SynchronizedBeforeSuite] PASSED [3.831 seconds] ------------------------------ SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS ------------------------------ quadlet system generator Running quadlet force remove all Should remove all quadlets at once /home/kavish/podman/test/e2e/quadlet_test.go:1339 Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet install /tmp/podman-e2e-554133839/subtest-3789943928/p/quadlet-remove-all-test-1766421735 /etc/containers/systemd/quadlet-remove-all-test-1766421735.volume /etc/containers/systemd/quadlet-remove-all-test-1766421735.container /etc/containers/systemd/quadlet-remove-all-test-1766421735.network Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet list --format json [ { "Name": "quadlet-remove-all-test-1766421735.container", "UnitName": "quadlet-remove-all-test-1766421735.service", "Path": "/etc/containers/systemd/quadlet-remove-all-test-1766421735.container", "Status": "inactive/dead", "App": ".quadlet-remove-all-test-1766421735.app" }, { "Name": "quadlet-remove-all-test-1766421735.network", "UnitName": "quadlet-remove-all-test-1766421735-network.service", "Path": "/etc/containers/systemd/quadlet-remove-all-test-1766421735.network", "Status": "inactive/dead", "App": ".quadlet-remove-all-test-1766421735.app" }, { "Name": "quadlet-remove-all-test-1766421735.volume", "UnitName": "quadlet-remove-all-test-1766421735-volume.service", "Path": "/etc/containers/systemd/quadlet-remove-all-test-1766421735.volume", "Status": "inactive/dead", "App": ".quadlet-remove-all-test-1766421735.app" } ] Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet rm -af quadlet-remove-all-test-1766421735.container quadlet-remove-all-test-1766421735.network quadlet-remove-all-test-1766421735.volume Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet list --format json [] Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay stop --all -t 0 Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay pod rm -fa -t 0 Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay rm -fa -t 0 • [0.578 seconds] ------------------------------ SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS ------------------------------ [SynchronizedAfterSuite] /home/kavish/podman/test/e2e/common_test.go:235 integration timing results quadlet system generator Running quadlet force remove all Should remove all quadlets at once 0.523858 [SynchronizedAfterSuite] PASSED [0.177 seconds] ------------------------------ Ran 1 of 2443 Specs in 4.624 seconds SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2442 Skipped PASS Ginkgo ran 1 suite in 8.290264111s Test Suite Passed

I also verified this against the latest main branch, and it passed there as well. Even with sudo ginkgo run -v --focus-file=quadlet_test.go test/e2e/, it’s still passing:

OUTPUT REDACTED quadlet system generator Running success quadlet test case logopt.container 0.013379 quadlet system generator Running success quadlet test case label.container 0.013625 quadlet system generator Running success quadlet test case exec.container 0.013705 quadlet system generator Running success quadlet test case pull.container 0.013814 quadlet system generator Running success quadlet test case readonly-notmpfs.container 0.014216 quadlet system generator Running success quadlet test case capabilities.container 0.014951 quadlet system generator Running quadlet force remove all Should remove all quadlets at once 0.503787 [SynchronizedAfterSuite] PASSED [0.175 seconds] ------------------------------ Ran 301 of 2443 Specs in 26.713 seconds SUCCESS! -- 301 Passed | 0 Failed | 0 Pending | 2142 Skipped PASS Ginkgo ran 1 suite in 31.515989818s Test Suite Passed

I'm not sure why it's failing.

I noticed the test was using Exit(0) in several places. I've updated it to use ExitCleanly() instead, which is the recommended Ginkgo matcher. This might resolve the F43 failure. I will push soon and see what's up.

Update: Done.

Honny1 · 2025-12-23T10:28:40Z

Not sure about the F43 failure, but the other tests appear to be flaky.

[FAIL] quadlet system generator Running quadlet force remove all [It] Should remove all quadlets at once
[+0894s]   /var/tmp/go/src/github.com/containers/podman/test/e2e/quadlet_test.go:1360

PTAL @mheon @Luap99

kavishgr · 2026-01-11T06:24:18Z

Ping. Is there anything else you need from my side to move this forward ?

Honny1 · 2026-04-02T15:27:38Z

Code LGTM. The CI failure appears legitimate, but I'm not sure how to resolve it. @containers/podman-maintainers @lsm5, could you take a look? Any ideas?

Honny1 · 2026-04-10T14:54:33Z

PTAL @containers/podman-maintainers

kavishgr · 2026-04-23T13:38:43Z

I think maybe the error is because the overlay mount wasn't fully torn down before AfterSuite tried to wipe the temp dir(output redacted):

unlinkat /tmp/CI_**/podman-e2e-.../subtest-**/p/root/overlay/**: directory not empty
< Exit [SynchronizedAfterSuite] TOP-LEVEL - /var/tmp/go/src/github.com/containers/podman/test/e2e/common_test.go:237

Looks like a DeferCleanup might be needed after podman install but I'm not totally sure:

DeferCleanup(func() {
    podmanTest.PodmanExitCleanly("stop", "-a", "-t", "0")
    podmanTest.PodmanExitCleanly("quadlet", "rm", "-af")
})

Honny1 · 2026-04-23T13:45:01Z

That could be it. But anyway, please rebase on main; we changed import paths.

packit-as-a-service · 2026-04-24T12:16:03Z

tmt tests failed for commit 3248d1e. @lsm5, @psss, @thrix please check.

kavishgr · 2026-04-24T13:34:50Z

The unlinkat error is still persisting, I'm removing the DeferCleanup.

packit-as-a-service · 2026-04-24T13:48:59Z

tmt tests failed for commit ad27bb4. @lsm5, @psss, @thrix please check.

Honny1

I think I found it.

packit-as-a-service · 2026-04-25T04:16:08Z

tmt tests failed for commit 24afe40. @lsm5, @psss, @thrix please check.

packit-as-a-service · 2026-04-25T14:57:10Z

tmt tests failed for commit 4f4c8b6. @lsm5, @psss, @thrix please check.

packit-as-a-service · 2026-04-25T15:19:34Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2026-04-29T07:57:28Z

tmt tests failed for commit 4f4c8b6. @lsm5, @psss, @thrix please check.

Honny1

Thanks, LGTM

PTAL @containers/podman-maintainers

psss · 2026-04-29T13:49:01Z

tmt tests failed for commit 4f4c8b6. @lsm5, @psss, @thrix please check.

Could you please rebase on the latest main?

…ntainer-tools#27653) Refactor removelist into sets Add quadlet rm --all test with safename add an integration test for quadlet rm --all(skip for remote clients) Signed-off-by: Kavish Gour <kavishgr@protonmail.com>

Ensure that the --all (-a) flag cannot be used simultaneously with specific quadlet arguments on the CLI. This prevents logical conflicts when a user provides both the --all flag and specific quadlets. - Add validation check in cmd/podman/quadlet/remove.go - Update the docs to document this behaviour with an example - Improve user feedback by explicitly stating why the command failed Signed-off-by: Kavish Gour <kavishgr@protonmail.com>

kavishgr · 2026-04-29T17:02:52Z

@psss Done. Rebased on latest main.

packit-as-a-service · 2026-04-29T17:35:55Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1 · 2026-05-08T18:49:25Z


+	// Remove .app and .asset files after the main quadlet removal loop
+	// This ensures they are cleaned up properly since they are not included in allQuadletPaths
+	for entry := range removeSet {


Not blocking: metadata files in removeSet are cleaned up regardless of whether the associated quadlet removals succeeded. If all quadlets in an app fail to remove (e.g., running without --force), the .app file is still deleted, orphaning them. This was the same behavior before this PR, just noting it as something to potentially address in a follow-up.

Honny1 · 2026-05-12T08:56:31Z

PTAL @containers/podman-maintainers @containers/podman-reviewers

l0rd · 2026-05-12T09:03:38Z

We want to remove support for .app files per #28335. In that PR, applications' files will be removed when using quadlet rm --all.

I am afraid that we should close this one.

kavishgr · 2026-05-12T09:29:18Z

Cool. Thanks for the update and thanks for the guidance throughout this PR. Closing this now.

openshift-ci Bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Dec 5, 2025

kavishgr mentioned this pull request Dec 5, 2025

Fix(quadlet): Deduplicate removal files for .app expansion (#27653) #27693

Closed

6 tasks

Honny1 reviewed Dec 5, 2025

View reviewed changes

Comment thread pkg/domain/infra/abi/quadlet.go Outdated

openshift-ci Bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Dec 5, 2025

kavishgr force-pushed the fix/issue-27647 branch from c299e69 to 40f3bff Compare December 5, 2025 17:03

Honny1 reviewed Dec 8, 2025

View reviewed changes

ygalblum reviewed Dec 8, 2025

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch 2 times, most recently from 7583fd1 to bc3a8f0 Compare December 8, 2025 18:32

kavishgr force-pushed the fix/issue-27647 branch from bc3a8f0 to 01fb0bc Compare December 8, 2025 18:42

Honny1 reviewed Dec 9, 2025

View reviewed changes

Comment thread test/e2e/quadlet_test.go

kavishgr force-pushed the fix/issue-27647 branch from 01fb0bc to 55c16c1 Compare December 9, 2025 15:11

Honny1 approved these changes Dec 17, 2025

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch from 55c16c1 to 06ccfe0 Compare December 18, 2025 16:18

Honny1 reviewed Dec 22, 2025

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch from 06ccfe0 to cf9f56d Compare December 23, 2025 04:28

Honny1 reviewed Dec 23, 2025

View reviewed changes

Comment thread test/apiv2/36-quadlets.at

Comment thread test/e2e/quadlet_test.go Outdated

kavishgr force-pushed the fix/issue-27647 branch from cf9f56d to bd3d648 Compare December 23, 2025 11:46

Honny1 approved these changes Apr 2, 2026

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch from a13ad64 to 3248d1e Compare April 24, 2026 12:03

kavishgr force-pushed the fix/issue-27647 branch from 3248d1e to ad27bb4 Compare April 24, 2026 13:35

Honny1 requested changes Apr 24, 2026

View reviewed changes

Comment thread test/e2e/quadlet_test.go

kavishgr force-pushed the fix/issue-27647 branch from ad27bb4 to 24afe40 Compare April 25, 2026 04:01

kavishgr force-pushed the fix/issue-27647 branch from 24afe40 to 4f4c8b6 Compare April 25, 2026 14:44

Honny1 approved these changes Apr 29, 2026

View reviewed changes

kavishgr added 2 commits April 29, 2026 20:57

kavishgr force-pushed the fix/issue-27647 branch from 4f4c8b6 to 1ab78c4 Compare April 29, 2026 16:59

kavishgr requested a review from Honny1 May 8, 2026 06:41

Honny1 reviewed May 8, 2026

View reviewed changes

kavishgr closed this May 12, 2026

Conversation

kavishgr commented Dec 5, 2025 • edited by Honny1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci Bot commented Dec 5, 2025

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kavishgr commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

kavishgr commented Dec 8, 2025

Uh oh!

ygalblum left a comment

Choose a reason for hiding this comment

Uh oh!

ygalblum Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

kavishgr Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

ygalblum Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

kavishgr Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Honny1 commented Dec 8, 2025

Uh oh!

packit-as-a-service Bot commented Dec 8, 2025

Uh oh!

packit-as-a-service Bot commented Dec 8, 2025

Uh oh!

packit-as-a-service Bot commented Dec 8, 2025

Uh oh!

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

kavishgr commented Dec 18, 2025

Uh oh!

Honny1 Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

kavishgr Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

kavishgr Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Honny1 commented Dec 23, 2025

Uh oh!

kavishgr commented Jan 11, 2026

Uh oh!

Honny1 commented Apr 2, 2026

Uh oh!

Honny1 commented Apr 10, 2026

Uh oh!

kavishgr commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Honny1 commented Apr 23, 2026

Uh oh!

packit-as-a-service Bot commented Apr 24, 2026

Uh oh!

kavishgr commented Apr 24, 2026

Uh oh!

packit-as-a-service Bot commented Apr 24, 2026

Uh oh!

Honny1 left a comment

kavishgr commented Dec 5, 2025 •

edited by Honny1

Loading

kavishgr commented Dec 8, 2025 •

edited

Loading

kavishgr Dec 23, 2025 •

edited

Loading

kavishgr commented Apr 23, 2026 •

edited

Loading